Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Incorrect macro expansion in extendWithPath #90

Open
robotlolita opened this issue Jul 30, 2015 · 3 comments
Open

Incorrect macro expansion in extendWithPath #90

robotlolita opened this issue Jul 30, 2015 · 3 comments

Comments

@robotlolita
Copy link
Owner

λ(data, path) -> extend(data, { path: path });

Gets expanded to:

function (data$2, path$2) {
  return extend(data, { path: path$2 });
};

Causing the novel loading to fail.

Probably related to some recent change in Sweet.js in how parenthesised expressions are handled, but needs further investigation :/

@igalic
Copy link
Contributor

igalic commented Jul 30, 2015

is that the reason i end up with this start screen since the last update.

raven startup: import a novel - but where's my old one?

how do i open my last written novel?
was that (auto)saved?
what does the × do?

@robotlolita
Copy link
Owner Author

Yes.

It auto-saves novels, so after you create one, the first screen will try to show all the novels you've created, but since the macro-expansion fails, it also fails to load the novels and present that screen. The error would be more obvious (i.e.: shown on the screen) if it wasn't for this: folktale/control.async#8.

The x at the top closes the application, the button to the left of that toggles between full-screen and windowed mode. I need to add some tooltips to that :/

robotlolita added a commit that referenced this issue Jul 30, 2015
This doesn't fix the underlying problem (needs to investigate changes in
both Sweet.js and lambda-chop), but at least fixes this particular
instance of the problem in Raven.

Addresses #90, but we still need to make sure that this problem doesn't
happen elsewhere.
@igalic
Copy link
Contributor

igalic commented Jul 30, 2015

something something accessibility something something

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants