Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy any received files (and corresponding approved files) to results folder #1883

Open
emanlove opened this issue Jan 20, 2024 · 0 comments

Comments

@emanlove
Copy link
Member

Occasionally there are errors within the approvaltests unit tests. These unit tests do post processing against know reults. When an eror occurs then the syst outputs the received files along side the files showing what was expected or the approved files. Like these

approved_file = '/home/runner/work/SeleniumLibrary/SeleniumLibrary/utest/test/keywords/approved_files/test_selenium_options_parser.test_split_options.approved.txt'
received_file = '/home/runner/work/SeleniumLibrary/SeleniumLibrary/utest/test/keywords/approved_files/test_selenium_options_parser.test_split_options.received.txt'

Notice that the file directory for these is not under the atest/results folder which our GitHub Action workflow will zip and archive. I am wondering if it is worth saving these files as part of that archive? (Actually is there is an unit test failure within GitHub actions we might also have the issue that there is no results folder because we never run the atests. might be a secondary problem to looks at as well.)

Recording here as a reminder to look into this ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant