Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API structure + put non-async handlers properly #569

Open
1 of 2 tasks
PawelPeczek-Roboflow opened this issue Aug 7, 2024 · 0 comments
Open
1 of 2 tasks
Labels
bug Something isn't working

Comments

@PawelPeczek-Roboflow
Copy link
Collaborator

Search before asking

  • I have searched the Inference issues and found no similar bug report.

Bug

The HTTP API module requires re-design. It is large and contains plenty of handlers. Some handlers (running non-asyncio code) are marked async improperly, potentially making the API less performant (fastapi handles both async and non-async handlers, just stamps need to be placed properly). We have this mistake by the virtue of error handling wrapper which is async-first.
Please re-design API as maintenance activity.

Environment

No response

Minimal Reproducible Example

No response

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant