Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods for smoothing/filtering, filter_ functions #41

Open
roaldarbol opened this issue Sep 17, 2024 · 3 comments
Open

Methods for smoothing/filtering, filter_ functions #41

roaldarbol opened this issue Sep 17, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@roaldarbol
Copy link
Owner

roaldarbol commented Sep 17, 2024

Can rely on the signal R package, which again implements the filtering functions from Matlab (I remember having used the filtfilt and butterworth before, they're common in human motor work, so maybe include them too as options). Also see the trajr package for their straightforward implementation of the Savitsky-Golay filter - check to be sure that the default values hold up (https://github.com/JimMcL/trajr/blob/c1d2005f03cc4f17e6cc277371ab26de1bf2bd8d/R/trajectory.R#L372).

Let's try to compile a list of what would be good methods to have:

  • filter_rollmean
  • filter_rollmedian
  • filter_highpass Bandwidth filtering #88
  • filter_lowpass
  • filter_highpass_fft
  • filter_lowpass_fft
  • filter_savgol
  • filter_kalman
@roaldarbol roaldarbol added the enhancement New feature or request label Sep 17, 2024
@roaldarbol roaldarbol added this to the Version 1.0 milestone Sep 17, 2024
@roaldarbol roaldarbol moved this to 🔬 Triage in animovement progress Sep 17, 2024
@roaldarbol

This comment was marked as outdated.

@roaldarbol roaldarbol changed the title Smoothing filters (Savitsky-Golay, butterworth) Methods for smoothing Dec 9, 2024
@roaldarbol
Copy link
Owner Author

Once data.table supports rolling median on their main branch, move over to that (see Rdatatable/data.table#2778).

@roaldarbol roaldarbol changed the title Methods for smoothing Methods for smoothing, smooth_by_ Dec 9, 2024
@roaldarbol roaldarbol changed the title Methods for smoothing, smooth_by_ Methods for smoothing, smooth_by_ functions Dec 9, 2024
@roaldarbol roaldarbol changed the title Methods for smoothing, smooth_by_ functions Methods for smoothing, smooth_ functions Dec 9, 2024
@roaldarbol
Copy link
Owner Author

Refactor smooth_movement into the above functions, all with the option on_derivatives.

@roaldarbol roaldarbol changed the title Methods for smoothing, smooth_ functions Methods for smoothing/filtering, filter_ functions Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🔬 Triage
Development

No branches or pull requests

1 participant