Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unassign keyup/change events before assigning #15

Open
NPC opened this issue Jul 26, 2018 · 0 comments
Open

Unassign keyup/change events before assigning #15

NPC opened this issue Jul 26, 2018 · 0 comments

Comments

@NPC
Copy link

NPC commented Jul 26, 2018

Hi,

To avoid multiple callback triggers if Sieve is initialized several times (otherwise no "destroy" is not really needed, which is nice), it makes sense to add this before the .on call:
settings.searchInput.off("keyup.sieve change.sieve");

PS I know I could create a PR for this, but I don't have time to figure it out, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant