Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust minimal presentation output to ensure no extra x-grades and y-grades are included #151

Open
mlesnick opened this issue Dec 14, 2019 · 0 comments

Comments

@mlesnick
Copy link
Contributor

mlesnick commented Dec 14, 2019

The output for the minimal presentation computation is handled as follows:

  1. Early in the computational pipeline, the unique x-grades and y-grades of the FI-Rep are printed as lists X and Y.

  2. After the minimal presentation is computed, the bigrades for each row and column are printed using an integer representation, where (X(i),Y(j)) is represented as (i,j).

  3. The matrix is printed in a column-sparse format.

Usually, many of the elements of X and Y will not be grades of generators or relations for the minimal presentation. So what we are outputting is usually not truly minimal. It is a rather superficial issue, but should be addressed.

This is related to issue #99, and perhaps both should be addressed at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant