New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status error codes to responses #66

Open

ckniffen opened this issue Dec 19, 2022 · 2 comments

Collaborator

ckniffen commented Dec 19, 2022

Error responses from the VHS always return a status of 200. We should leverage 404 and 500s at the very least.

404 example https://github.com/ripple/validator-history-service/blob/main/src/api/routes/v1/validator.ts#L233
500 example https://github.com/ripple/validator-history-service/blob/main/src/api/routes/v1/validator.ts#L275

sohammk08 commented Oct 19, 2023

Is this issue still valid? And if yes, should I work on it?

Collaborator

mvadari commented Oct 19, 2023

I believe so, and sure

sohammk08 mentioned this issue

Added status error codes to responses #151

Closed

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment