Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amendment name missing on sidechain #192

Open
bigcjat opened this issue Jan 9, 2024 · 2 comments
Open

Amendment name missing on sidechain #192

bigcjat opened this issue Jan 9, 2024 · 2 comments

Comments

@bigcjat
Copy link

bigcjat commented Jan 9, 2024

VHS is running locally on a xahau validator, yet xahau amendments do not have their name attached. Seems like the names can be sourced from the local validator rather than where ever it is getting them as the name is found in 'xahaud feature'

Screen Shot 2024-01-09 at 2 31 14 PM
@ckniffen
Copy link
Collaborator

The VHS is meant to be run against public infra which does not yet expose that endpoint. Hopefully it will be made available in 2.1. it wouldn't hurt to try every so often though.

@mvadari
Copy link
Collaborator

mvadari commented Jan 10, 2024

The amendment names are fetched from rippled source code because there's no way to get it from the hash:

const response = await axios.get(
'https://raw.githubusercontent.com/ripple/rippled/develop/src/ripple/protocol/impl/Feature.cpp',
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants