Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Currency type in tx metadata details #925

Open
mvadari opened this issue Jan 31, 2024 · 0 comments · May be fixed by #973
Open

Use Currency type in tx metadata details #925

mvadari opened this issue Jan 31, 2024 · 0 comments · May be fixed by #973
Labels
bug Something isn't working cleanup This issue is for cleaning up existing code. good first issue Good for newcomers

Comments

@mvadari
Copy link
Collaborator

mvadari commented Jan 31, 2024

Currencies that aren't 3 letters are still hex in this output.

Example:
image

(Ideally, the first line would read It deleted a XRP/MB589 offer node owned by rBjBZPghaXLmNmgzU1gYi5UEfwinJEjcja with sequence #69545115)

The Description section has the same problem:
image

https://livenet.xrpl.org/transactions/5AA36C90A9337F876B2C89270AE705A941333D5DACBF9F4199592F71AE1CC604/detailed
@mvadari mvadari added bug Something isn't working good first issue Good for newcomers cleanup This issue is for cleaning up existing code. labels Jan 31, 2024
@pdp2121 pdp2121 linked a pull request Jul 9, 2024 that will close this issue
Draft
10 tasks
@mvadari mvadari linked a pull request Jul 9, 2024 that will close this issue
fix: use Currency in the metadata description #973
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cleanup This issue is for cleaning up existing code. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use Currency in the metadata description ripple/explorer
1 participant
@mvadari