Use feature rpc for EnableAmendment #1052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdp2121
changed the title
mvadari
reviewed
Oct 2, 2024
| </I18nextProvider> | ||
| </Router>, | ||
| ) | ||
|
|
||
| beforeEach(() => { | ||
| client = new MockWsClient() |
There was a problem hiding this comment.
I believe these have to be torn down
mvadari
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
With the new feature RPC introduced in rippled 2.2.0, EnableAmendment tx Simple page can populate its data using amendment id without dependence on xrpl.org and rippled docs (which change pretty frequently):
https://github.com/ripple/explorer/blob/staging/src/containers/shared/amendmentUtils.ts
The logic would be simplified and consistency would be improved
This resolves: #1001
Type of Change