Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New domain for BrowserID, minor security questions #3

Open
SamPenrose opened this issue Aug 21, 2013 · 0 comments
Open

New domain for BrowserID, minor security questions #3

SamPenrose opened this issue Aug 21, 2013 · 0 comments

Comments

@SamPenrose
Copy link

Hey, thanks so much for implementing BrowserID! We changed the single "browserid.org" domain to a pair:

  1. https://login.persona.org/ for include.js
  2. https://verifier.login.persona.org/ for the /verify action.

I can do a branch and PR for this, but I'm new to Ruby and don't want to break your conventions for handling constants or the relationship between this repo and devise-browserid. (If you aren't attempting to load include.js -- I couldn't tell -- I can just swap in the new constant and do a PR.)

From scanning your code and the net:http docs I couldn't see where you were checking the SSL certification for the /verify domain -- apologies if I missed it. Finally, at https://github.com/ringe/warden-browserid/blob/master/lib/warden-browserid/strategy.rb#L28, does that value come from the client (bad) or from server state (good)?

Thanks again for your awesome support of Persona!
--Sam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant