Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-exact Implementation of CNN Sentence Classifier #25

Open
iamkissg opened this issue Jun 5, 2018 · 1 comment
Open

Non-exact Implementation of CNN Sentence Classifier #25

iamkissg opened this issue Jun 5, 2018 · 1 comment

Comments

@iamkissg
Copy link

iamkissg commented Jun 5, 2018

Hi Richard,

I just read the paper "Convolutional Neural Networks for Sentence Classification" and your blog as well as code.

It seems that your implementation is not the network described in the paper. According to the paper, the convolution layers are parallel. However, they are serial in your implementation.

You may re-implement you network to see which one achieves better performance.

@richliao
Copy link
Owner

The final concatenation that merges different windows is what you referred to as parallel. That is what I have implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants