Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PlaybookRunner behaviour #130

Open
jan-zmeskal opened this issue May 11, 2020 · 0 comments
Open

Update PlaybookRunner behaviour #130

jan-zmeskal opened this issue May 11, 2020 · 0 comments

Comments

@jan-zmeskal
Copy link

SInce introduction of upload_playbook parameter to PlaybookRunner.run() method, we allow the users to upload the target playbook on their own to a remote resources. However, vars_files and vault_password_file parameters still require local paths and still upload local files to a remote host. We need to change PlaybookRunner.run() interface so that either

  • all provided paths are local and all the files get uploaded to a remote host automatically or
  • all provided paths are remote and it's up to the user to get those files to a remote resources

This should be driven by the value passed to upload_playbook parameter. For more context, see my conversation with Lukas here: https://github.com/rhevm-qe-automation/python-rrmngmnt/pull/129/files#r422892028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant