Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent logging and document how to use it #436

Open
sevdog opened this issue Aug 1, 2024 · 0 comments
Open

Use consistent logging and document how to use it #436

sevdog opened this issue Aug 1, 2024 · 0 comments

Comments

@sevdog
Copy link

sevdog commented Aug 1, 2024

Currently inside this package there are few methods which has a logger enabled. Some are configured as getLogger("health-check") while other as getLogger(__name__). This may cause confusion when someone has to configure logging since he will expects a package to log under a single main logger while current configuration leads to two loggers: "health-check" and "health_check", one with the dash and the other with the underscore.

It would be better to have a single logger, to ease configuration for other projects which use this as a dependency, and only where it is used (since some files declares a logger which is never used afterwards).

Also currently there is no documentation regarding how to use the "health-check" logger, which would be very useful to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant