Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BASINS] Time series shift by one time step #8

Open
mishranurag opened this issue Oct 7, 2016 · 3 comments
Open

[BASINS] Time series shift by one time step #8

mishranurag opened this issue Oct 7, 2016 · 3 comments

Comments

@mishranurag
Copy link
Contributor

It has been noted by Tim Cera and verified by Anurag, that when you display a time series in BASINS or SARA, it shows that the data has been shifted by one time step.

I have attached examples of outputs.

annie_export.txt
SARA_export_101.txt
wdmtoolbox_extract_101.txt
wdmutil_export_101.txt

@MarkGrayRESPEC
Copy link
Contributor

My impression is that this is mostly just a labeling issue, not actually a big bug. We internally store the time at the end of the interval and in some cases that is the value displayed instead of the beginning of the interval which would often look better. Given some time we could make a push to figure out what interval each dataset uses and choose the most appropriate labeling convention. This will be affected by how the data was read, especially If it was imported by a script.

@timcera
Copy link

timcera commented Nov 8, 2016

The biggest issue is the break with the past. SARA and BASINS are inconsistent with the other exports (annie, wdmutil, and wdmtoolbox). My wdmtoolbox is following the annie/wdmutil convention so that isn't a surprise that it matches the tradition.

@mishranurag mishranurag added the bug label Dec 6, 2016
@mishranurag
Copy link
Contributor Author

I noticed that the SARA and BASINS show the time step as the end of the time interval, by default. In WDMUtil, if I check box for "End of Interval" in the Date Format option, I see the same labeling as SARA TS Utility and BASINS.

I will keep this thread open for discussion, but I do not think this should be considered as a bug anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants