Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.3.1 removed module compliance_fixes.linkedin #483

Open
den4uk opened this issue Jan 30, 2022 · 4 comments
Open

Version 1.3.1 removed module compliance_fixes.linkedin #483

den4uk opened this issue Jan 30, 2022 · 4 comments
Milestone

Comments

@den4uk
Copy link

den4uk commented Jan 30, 2022

The latest release (1.3.1) has a missing module for linkedin compliance fixes.

ImportError: cannot import name 'linkedin_compliance_fix' from 'requests_oauthlib.compliance_fixes'

v1.3.0 still has it: https://github.com/requests/requests-oauthlib/blob/v1.3.0/requests_oauthlib/compliance_fixes/linkedin.py

The removal without a deprecation caused undesired side effects.
So far, I managed to catch the change in unit tests, however, expect it to cascade for the rest of the world 🌎 📉

@JonathanHuot
Copy link
Contributor

Agreed the version should have been bumped to 1.4.0 instead. It has been missed somehow. Or a deprecation is also a good idea.

Note that the linkedin seems no longer required as described here #397

@den4uk
Copy link
Author

den4uk commented Feb 19, 2022

Thanks for acknowledgement. Given the breaking changes, this should have really better been a 2.0.
It is what it is now. I hope there aren't too many fires out there :)

@jtroussard
Copy link
Contributor

@JonathanHuot @den4uk Would it be problematic to release a quick patch? Revert the removal, and add a deprecation warning. Removal can return for 1.4. Or is this too much of a snip snap situation? #485 ???

@JonathanHuot
Copy link
Contributor

Since you already have done all the work @jtroussard, I think it is a reasonable ask :) Let's me take care of it.

@JonathanHuot JonathanHuot modified the milestones: 1.4.0, 1.3.2 Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants