Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two letter virtual folders mistaken for locales #1292

Open
invisiblethreat opened this issue Dec 7, 2019 · 3 comments · May be fixed by #7440
Open

Two letter virtual folders mistaken for locales #1292

invisiblethreat opened this issue Dec 7, 2019 · 3 comments · May be fixed by #7440
Assignees
Labels
bug Something isn't working contrib-easy Easy dev difficulty for contribution

Comments

@invisiblethreat
Copy link

When linking to something before it exists, like db/postgres from "home" and then clicking through to the dialogue to create the new page, you end up with an unlocalized page creation dialog that you can still use. Upon clicking through and creating the page, when you attempt to save, you receive an SQL error. This is potentially due to the db section being mistaken for the locale.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'home'
  2. Edit the page to add a link to a new "short" virtual folder/page that does not yet exist, like db/postgres
  3. Click through the creation dialog
  4. Attempt to save the page and capture the error

Expected behavior
Throw an error for unsupported locale/action. The modal for creating a new pages does not permit short paths that would conflict with this locales, which may be good enough, but I wanted to raise this issue if folks though it would be helpful to trap it.

Screenshots
image

image

image

image

Host Info (please complete the following information):

  • OS: Docker, requarks/wiki:2
  • Wiki.js version: 2.0.12
  • Database engine: MariaDB 10.4.7-MariaDB-1:10.4.7+maria~bionic

Additional context
Again, this is an edge case that I'm not sure that many folks will hit, so it might not be worth the code to fix/prevent, but I wanted to let you know. Thanks for the cool project!

@NGPixel NGPixel added bug Something isn't working contrib-easy Easy dev difficulty for contribution labels Dec 8, 2019
@mielipuolinen
Copy link

mielipuolinen commented Jan 17, 2020

Can confirm this issue too, run into it few times before I realized what was happening. :)

Pages can be renamed into two-character path names which causes issues too and things start to act weird.

@juliendms
Copy link

juliendms commented Mar 11, 2020

There is also an issue with Assets folder with only two letters. You can add pictures in those folders, but when you add them on the page, it returns a 404 error instead of loading the images.
Cf. https://requarks.slack.com/archives/C49J7AB8R/p1583228731093200

@BPowell76
Copy link

BPowell76 commented Nov 16, 2024

I'm going to give a crack at this, but I've got to study how everything comes together. The plan is to ignore the path all together if multilingual pages is disabled as turning that setting on prepends the locale code to the path. If the locale is prepended to the path, then creating a two-letter page/path doesn't trigger the issue.

@BPowell76 BPowell76 linked a pull request Nov 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contrib-easy Easy dev difficulty for contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants