Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Support If-Modified-Since #112

Open
tempusfrangit opened this issue Dec 12, 2023 · 3 comments
Open

Enhancement: Support If-Modified-Since #112

tempusfrangit opened this issue Dec 12, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tempusfrangit
Copy link
Contributor

tempusfrangit commented Dec 12, 2023

PGET should support if-modified-since logic

This should be opt-in via cli-option. This might be duplicate of #61

@tempusfrangit tempusfrangit added enhancement New feature or request good first issue Good for newcomers labels Dec 12, 2023
@MacOS
Copy link

MacOS commented Jan 24, 2024

Is anyone working on this? If no, I'm happy to take that over.

@tempusfrangit
Copy link
Contributor Author

tempusfrangit commented Jan 24, 2024

It currently does not have anyone working on it.

There was some internal discussion about using mtime or ctime of the local file to create the IMS check. I don't think that discussion was captured in the issue.

There is also a question how the range-request stuff ends up working with IMS. I haven't looked into the standard for that.

@MacOS
Copy link

MacOS commented Jan 25, 2024

In short, there has been already a lot of discussion about it that is not written down, and no one has come up with an implementation to argue about. This seems to me, as if I should not invest in it - am I right @tempusfrangit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants