Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper display of nested dict in param. #575

Open
lkhphuc opened this issue Mar 17, 2021 · 1 comment
Open

Proper display of nested dict in param. #575

lkhphuc opened this issue Mar 17, 2021 · 1 comment
Labels
help wanted Extra attention is needed type/enhancement Something new

Comments

@lkhphuc
Copy link

lkhphuc commented Mar 17, 2021

Screenshot 2021-03-17 at 12 51 28

Support proper display of nested params file since many application provided a nested dictionary of parameters.
For example:

Params
data._target_:             project.data.MNISTDataModule
data.batch_size:         32
model.base:                resnet18
model.pretrain:          true
model.optim.lr:          1e-3
@bfirsh
Copy link
Member

bfirsh commented Mar 17, 2021

Yes! Thanks for the suggestion. A simple solution would be to just format the JSON with newlines and indenting. Another alternative would be to have a YAML-like value, which might be easier to read and see the structure of.

@bfirsh bfirsh added help wanted Extra attention is needed type/enhancement Something new labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type/enhancement Something new
Projects
None yet
Development

No branches or pull requests

2 participants