Clarify default install directory behaviour #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install script seems to suggest `/usr/local/bin` as the default install directory. However, pressing `RETURN` will actually set the install dir to an empty string. The error message is not helpful as it then reads `The directory does not exist.` (note the additional space). This fix makes the script behave as expected: pressing `RETURN` accepts the default suggestion. Signed-off-by: André Knörig <[email protected]>
|
Addresses issue #1914 |
yorickvP
approved these changes
Sep 3, 2024
|
ran into the same issue - was also expecting the default/placeholder to be on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install script seems to suggest
/usr/local/binas the default install directory. However, pressingRETURNwill actually set the install dir to an empty string. The error message is not helpful as it then readsThe directory does not exist.(note the additional space).This fix makes the script behave as expected: pressing
RETURNaccepts the default suggestion.(Also factors out the directory selection into a function.)