Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with einops #2

Open
CreamNuts opened this issue Nov 30, 2021 · 3 comments
Open

Incompatible with einops #2

CreamNuts opened this issue Nov 30, 2021 · 3 comments

Comments

@CreamNuts
Copy link

Thanks for your nice project. But it is not compatible with einops.
Einops is convenient for pytorch user, and I think many people use it.
I hope it works on einops, too. Thank you.

@rentruewang
Copy link
Owner

Good point. I'll be working on it. Feel free to add more feature requests!

@rentruewang
Copy link
Owner

Ok. After quickly skimming over einops's source code, I noticed that they call torch.* functions behind the scenes. That means their functions will directly work with Koila, because Koila uses PyTorch's extension API.

With that being said, not all torch.* functions are implemented yet, and it probably requires some testing. So I'll leave it open for now, and see what I can do when I have some time.

@CreamNuts
Copy link
Author

I'm looking forward to implementing it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants