ttype referenced before assignment

[louwers]

            if rel_p.startswith('http'):

                img = rel_p
                local_filename, headers = urllib.request.urlretrieve(rel_p)
                size = ImageHandler.get_image_size(local_filename)
                if size:
                    w, h, ttype = size

                    FMT = u'''
                        <img src="data:image/{}" class="centerImage" {}>
                    '''
                img = ttype + ";base64," + get_as_base64(img)

[Derpius]

From that code snippet, I'd assume that you're not assigning anything to ttype prior to if size:?
If not then if if size: returns false, ttype never gets assigned, and there is no check if it's None before trying to use it when assigning img

[louwers]

Yup, that's the problem.

[Derpius]

Happy to help.

---

Please close the issue yourself by pressing the close issue button, as the developer of this plugin appears to be inactive (no commits since two years ago, no resolved issues since around the same time etc.)

[louwers]

I'll close it when it's fixed.

[Derpius]

Can you program in python and fix it yourself? If not then it wont get fixed because, as per my previous comment, the developer has been inactive for around 2 years.

[Derpius]

I could probably fix it if you're unable to if it's a pressing issue

[louwers]

Then I'll wait until he rises again. :-)

[Derpius]

if rel_p.startswith('http'):
    img = rel_p
    local_filename, headers = urllib.request.urlretrieve(rel_p)
    size = ImageHandler.get_image_size(local_filename)
    if size:
        w, h, ttype = size

        FMT = u'<img src="data:image/{}" class="centerImage" {}>'
        img = ttype + ";base64," + get_as_base64(img)

Fixed.
Don't know if it's gonna cause other errors elsewhere in the plugin as I can't test it at the moment.

[louwers]

OK I'll close the issue when it's merged.