-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Multiple Filters not Supported by Supabase Realtime #6360
Comments
Hello @amerryma, Can you please give us the |
Hello @amerryma, thanks for the issue. We discussed with the core team and decided not to add After removing |
My workaround for now was picking one filter that did 90% of the server side filtering then did the rest on the client side. So you're saying that you will remove the filtering altogether? |
I was wrong. In this use case, the filters must work. We'll investigate this issue and see what we can do. We're currently considering showing a warning when multiple filters are used and allowing users to override the |
I've also bumped an issue directly inside supabase/realtime to see what the status is there. |
Until there are any updates in the supabase side, we should have this working without an error. Picking the first filter will work for many cases but it must be configurable (like If Supabase starts supporting multiple filters in the future, we can just deprecate the Maybe @alicanerdurmaz can provide a detailed description for the implementation we want and it will be a guide for anyone interested in working on this issue 🚀 🚀 |
I think it would be good to warn if there is more than one filter and allow the user to override the filter if needed.
|
Describe the bug
Right now, Supabase Realtime does not support multiple filters. If used, the live provider for supabase will send an invalid filter payload, causing the realtime request to fail.
Steps To Reproduce
Expected behavior
I think we should either log a warning if we see multiple filters, or naively take the first one?
Packages
Additional Context
See here for Refine's implementation, where it is joining each filter with a comma.
https://github.com/refinedev/refine/blame/8be95d808ae2f3f280ebd015bd95eb04238fe463/packages/supabase/src/liveProvider/index.ts#L67
See here for feature that is being discussed. No real activity it seems.
supabase/realtime#486
supabase/realtime-js#97
The text was updated successfully, but these errors were encountered: