Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP docs Vale review bot issues #744

Open
rohennes opened this issue Mar 20, 2024 · 20 comments
Open

OCP docs Vale review bot issues #744

rohennes opened this issue Mar 20, 2024 · 20 comments

Comments

@rohennes
Copy link
Collaborator

rohennes commented Mar 20, 2024

Container issue to report bugs with the ocpdocs-vale-bot:

PPC flagged incorrectly:
https://github.com/openshift/openshift-docs/pull/72761/files#r1532156043
(FIXED)

VT-d flagged incorrectly (?):
openshift/openshift-docs#72761 (comment)
(FIXED)

- openshift/openshift-docs#73626 (comment)
openshift/openshift-docs#72364 (comment)
Use 'Kubelet' rather than 'Kubelet'
Use 'VNIC' rather than 'VNIC'.
Seems to be some issue with capitalization for suggestioned terms.
(FIXED)

@rohennes
Copy link
Collaborator Author

@aireilly - record rule fixes here as they come up?

@aireilly
Copy link
Member

Good idea. Fixed a few already.

@aireilly
Copy link
Member

#743

@aireilly
Copy link
Member

#741

@aireilly
Copy link
Member

#739

@aireilly
Copy link
Member

@rohennes
Copy link
Collaborator Author

#740

@aireilly
Copy link
Member

#747

@rohennes
Copy link
Collaborator Author

#745

@rohennes
Copy link
Collaborator Author

@rohennes
Copy link
Collaborator Author

#748 kubelet stats receiver

@rohennes
Copy link
Collaborator Author

#750 - Removes Azure as an error term as too many false positives

@aireilly
Copy link
Member

aireilly commented Apr 3, 2024

@aireilly
Copy link
Member

aireilly commented Apr 3, 2024

@aireilly
Copy link
Member

aireilly commented Apr 3, 2024

The VNIC/vNIC one is annoying. I think maybe a bug in Vale. We should create a test case and submit. Edit: errata-ai/vale#802

Another variation seen here: openshift/openshift-docs#66061 (comment)

@rohennes
Copy link
Collaborator Author

rohennes commented Apr 11, 2024

openshift/openshift-docs#74513 - fixes xrefs not getting flagged because of bad entry in accept.txt Vocab

@aireilly
Copy link
Member

#764

@aireilly
Copy link
Member

Closed attribute block should not fire for JSON in a code block:

https://github.com/openshift/openshift-docs/pull/74739/files/c270a8084990674061e268223deaba4cb21a2615#r1576081106

@aireilly
Copy link
Member

Closed attribute block should not fire for JSON in a code block:

https://github.com/openshift/openshift-docs/pull/74739/files/c270a8084990674061e268223deaba4cb21a2615#r1576081106

#777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants