Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate running Quarkus project generator without waiting for Java extension #323

Open
datho7561 opened this issue Dec 1, 2020 · 2 comments · May be fixed by #368
Open

Investigate running Quarkus project generator without waiting for Java extension #323

datho7561 opened this issue Dec 1, 2020 · 2 comments · May be fixed by #368
Assignees
Labels
enhancement New feature or request

Comments

@datho7561
Copy link
Contributor

When you are in rootless mode (no folder open, just individual files), the command to generate a Quarkus project doesn't appear. It could be helpful to display the command in this mode, since generating the project doesn't depend on being in a particular folder.

@datho7561 datho7561 added the enhancement New feature or request label Dec 1, 2020
@datho7561 datho7561 self-assigned this Jun 16, 2021
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jun 22, 2021
Work in progress.
Instead of directly depending on vscode-microprofile,
send the user a notification with a button to install the extension.
The user can reject the installation.
They will be free to use:
 * qute syntax highlight
 * properties file highlight
 * project generator
but no new language features will appear,
and they will be prompted to install vscode-microprofile when attempting
to run commands that require it.

Since vscode-quarkus doesn't wait on vscode-microprofile starting
anymore, it can start the project generator without starting
vscode-microprofile or even vscode-java. This allows for it to work in
rootless mode.

Closes redhat-developer#323

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jun 22, 2021
Work in progress.
Instead of directly depending on vscode-microprofile,
send the user a notification with a button to install the extension.
The user can reject the installation.
They will be free to use:
 * qute syntax highlight
 * properties file highlight
 * project generator
but no new language features will appear,
and they will be prompted to install vscode-microprofile when attempting
to run commands that require it.

Since vscode-quarkus doesn't wait on vscode-microprofile starting
anymore, it can start the project generator without starting
vscode-microprofile or even vscode-java. This allows for it to work in
rootless mode.

Closes redhat-developer#323

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jun 22, 2021
Work in progress.
Instead of directly depending on vscode-microprofile,
send the user a notification with a button to install the extension.
The user can reject the installation.
They will be free to use:
 * qute syntax highlight
 * properties file highlight
 * project generator
but no new language features will appear,
and they will be prompted to install vscode-microprofile when attempting
to run commands that require it.

Since vscode-quarkus doesn't wait on vscode-microprofile starting
anymore, it can start the project generator without starting
vscode-microprofile or even vscode-java. This allows for it to work in
rootless mode.

Closes redhat-developer#323

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 linked a pull request Jun 22, 2021 that will close this issue
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Jun 28, 2021
See redhat-developer/vscode-microprofile#58

Consume the API provided by vscode-microprofile in order to
wait for lsp4mp to start when running commands that interact with
lsp4mp.

Closes redhat-developer#323

Signed-off-by: David Thompson <[email protected]>
@rgrunber
Copy link
Member

FWIW, I was able to see the command to create a Quarkus project with no folder opened (from the command palette), but I did have to wait on vscode-microprofile + vscode-java to initialize.

@datho7561
Copy link
Contributor Author

Yes, I also can confirm this behaviour. Should I close this issue then, and open another one for investigating running the generator without starting vscode-java?

@rgrunber rgrunber changed the title Support generating a Quarkus project in rootless mode Investigate running Quarkus project generator without waiting for Java extension Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants