Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to NodeJS 18 #176

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Update to NodeJS 18 #176

merged 1 commit into from
Feb 21, 2024

Conversation

datho7561
Copy link
Contributor

Closes #167

Signed-off-by: David Thompson [email protected]

@datho7561 datho7561 requested a review from fbricon February 1, 2024 16:37
@datho7561
Update to NodeJS 18
7c17d1e 
Closes redhat-developer#167

Signed-off-by: David Thompson <[email protected]>
rgrunber
rgrunber approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well for me. Tested by opening up a microprofile project and viewing all the properties under microprofile-config.properties.

@datho7561 datho7561 merged commit 76b5b5a into redhat-developer:master Feb 21, 2024
3 checks passed
@datho7561 datho7561 deleted the update-to-node-18 branch February 21, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

@fbricon fbricon Awaiting requested review from fbricon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 14 is EOL
2 participants
@datho7561 @rgrunber