Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to vscode-languageclient 8.0.2 #145

Merged

Conversation

JessicaJHee
Copy link
Contributor

Signed-off-by: Jessica He [email protected]

@datho7561 datho7561 self-requested a review January 27, 2023 19:50
@datho7561
Copy link
Contributor

There is a compilation error in one of the test files (you can see it if you run npm test).

@datho7561
Copy link
Contributor

(sorry, didn't realize you already had a PR for this)

@JessicaJHee
Copy link
Contributor Author

(sorry, didn't realize you already had a PR for this)

No that's my bad, I should have created an issue for it first or included it in my stand up

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Jessica!

@datho7561
Copy link
Contributor

datho7561 commented Jan 27, 2023

Closes #146

@datho7561
Copy link
Contributor

datho7561 commented Jan 27, 2023

Let me check why the tests are failing...

Yep, its just #112 (comment)

@datho7561 datho7561 merged commit 62ffa21 into redhat-developer:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants