Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestrator): update openapi flpath-1893 #90

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions workspaces/orchestrator/.changeset/red-seahorses-give.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@red-hat-developer-hub/backstage-plugin-orchestrator-backend': patch
'@red-hat-developer-hub/backstage-plugin-orchestrator-common': patch
---

update openapi flpath-1893
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ describe('scenarios to verify mapToWorkflowOverviewDTO', () => {
getProcessInstancesStatusDTOFromString(overview.lastRunStatus),
);
expect(result.category).toBe('assessment');
expect(result.avgDurationMs).toBe(overview.avgDurationMs);
expect(result.description).toBe(overview.description);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export function mapToWorkflowOverviewDTO(
name: overview.name,
format: overview.format,
workflowId: overview.workflowId,
avgDurationMs: overview.avgDurationMs,
description: overview.description,
lastRunId: overview.lastRunId,
lastRunStatus: overview.lastRunStatus
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ interface WorkflowOverviewParams {
lastTriggeredMs?: number;
lastRunStatus?: ProcessInstanceStateValues;
category?: string;
avgDurationMs?: number;
description?: string;
}
export function generateTestWorkflowOverview(
Expand All @@ -52,7 +51,6 @@ export function generateTestWorkflowOverview(
params.lastTriggeredMs ?? Date.parse('2024-02-09T10:34:56Z'),
lastRunStatus: params.lastRunStatus ?? ProcessInstanceState.Completed,
category: params.category ?? 'assessment', // validate input
avgDurationMs: params.avgDurationMs ?? 1000,
description: params.description ?? 'Test Workflow Description',
};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@ describe('getWorkflowOverviewById', () => {
expect(overviewV2.lastTriggeredMs).toBeUndefined();
expect(overviewV2.lastRunStatus).toBeUndefined();
expect(overviewV2.category).toEqual('infrastructure');
expect(overviewV2.avgDurationMs).toBeUndefined();
expect(overviewV2.description).toBeUndefined();
});

Expand Down
567 changes: 281 additions & 286 deletions workspaces/orchestrator/plugins/orchestrator-common/report.api.md

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
5fcc8d37339b5241ec2435343b540d2aec5c6873
91326c20d83a0f45099f3ba29eab13709d60a938

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -660,12 +660,6 @@ export interface WorkflowOverviewDTO {
* @memberof WorkflowOverviewDTO
*/
'category'?: WorkflowCategoryDTO;
/**
*
* @type {number}
* @memberof WorkflowOverviewDTO
*/
'avgDurationMs'?: number;
/**
*
* @type {string}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1224,10 +1224,6 @@
"category" : {
"$ref" : "#/components/schemas/WorkflowCategoryDTO"
},
"avgDurationMs" : {
"minimum" : 0,
"type" : "number"
},
"description" : {
"type" : "string"
}
Expand Down Expand Up @@ -2844,19 +2840,19 @@ <h3>Usage and SDK Samples</h3>
"http://localhost/v2/workflows/instances" \
-d '{
&quot;paginationInfo&quot; : {
&quot;offset&quot; : 5.962133916683182,
&quot;pageSize&quot; : 1.4658129805029452,
&quot;offset&quot; : 1.4658129805029452,
&quot;pageSize&quot; : 6.027456183070403,
&quot;orderDirection&quot; : &quot;ASC&quot;,
&quot;orderBy&quot; : &quot;orderBy&quot;,
&quot;totalCount&quot; : 5.637376656633329
&quot;totalCount&quot; : 5.962133916683182
},
&quot;filters&quot; : {
&quot;paginationInfo&quot; : {
&quot;offset&quot; : 5.962133916683182,
&quot;pageSize&quot; : 1.4658129805029452,
&quot;offset&quot; : 1.4658129805029452,
&quot;pageSize&quot; : 6.027456183070403,
&quot;orderDirection&quot; : &quot;ASC&quot;,
&quot;orderBy&quot; : &quot;orderBy&quot;,
&quot;totalCount&quot; : 5.637376656633329
&quot;totalCount&quot; : 5.962133916683182
},
&quot;filters&quot; : {
&quot;filters&quot; : [ null, null ],
Expand Down Expand Up @@ -3757,11 +3753,11 @@ <h3>Usage and SDK Samples</h3>
"http://localhost/v2/workflows/{workflowId}/instances" \
-d '{
&quot;paginationInfo&quot; : {
&quot;offset&quot; : 5.962133916683182,
&quot;pageSize&quot; : 1.4658129805029452,
&quot;offset&quot; : 1.4658129805029452,
&quot;pageSize&quot; : 6.027456183070403,
&quot;orderDirection&quot; : &quot;ASC&quot;,
&quot;orderBy&quot; : &quot;orderBy&quot;,
&quot;totalCount&quot; : 5.637376656633329
&quot;totalCount&quot; : 5.962133916683182
},
&quot;filters&quot; : {
&quot;filters&quot; : [ null, null ],
Expand Down Expand Up @@ -5452,11 +5448,11 @@ <h3>Usage and SDK Samples</h3>
"http://localhost/v2/workflows/overview" \
-d '{
&quot;paginationInfo&quot; : {
&quot;offset&quot; : 5.962133916683182,
&quot;pageSize&quot; : 1.4658129805029452,
&quot;offset&quot; : 1.4658129805029452,
&quot;pageSize&quot; : 6.027456183070403,
&quot;orderDirection&quot; : &quot;ASC&quot;,
&quot;orderBy&quot; : &quot;orderBy&quot;,
&quot;totalCount&quot; : 5.637376656633329
&quot;totalCount&quot; : 5.962133916683182
},
&quot;filters&quot; : {
&quot;filters&quot; : [ null, null ],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
| **lastTriggeredMs** | **BigDecimal** | | [optional] [default to null] |
| **lastRunStatus** | [**ProcessInstanceStatusDTO**](ProcessInstanceStatusDTO.md) | | [optional] [default to null] |
| **category** | [**WorkflowCategoryDTO**](WorkflowCategoryDTO.md) | | [optional] [default to null] |
| **avgDurationMs** | **BigDecimal** | | [optional] [default to null] |
| **description** | **String** | | [optional] [default to null] |

[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -379,9 +379,6 @@ components:
$ref: '#/components/schemas/ProcessInstanceStatusDTO'
category:
$ref: '#/components/schemas/WorkflowCategoryDTO'
avgDurationMs:
type: number
minimum: 0
description:
type: string
required:
Expand Down