Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary files from migrated plugins #77

Merged
merged 1 commit into from
Nov 26, 2024
Merged

chore: remove unnecessary files from migrated plugins #77

merged 1 commit into from
Nov 26, 2024

Conversation

04kash
Copy link
Collaborator

@04kash 04kash commented Nov 25, 2024 •
edited
Loading

Hey, I just made a Pull Request!

This PR removes unnecessary files from all migrated plugins.

FIxes: https://issues.redhat.com/browse/RHIDP-4938

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Nov 25, 2024

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @red-hat-developer-hub/backstage-plugin-bulk-import-backend
  • @red-hat-developer-hub/backstage-plugin-bulk-import-common
  • @red-hat-developer-hub/backstage-plugin-bulk-import
  • @red-hat-developer-hub/backstage-plugin-openshift-image-registry
  • @red-hat-developer-hub/backstage-plugin-orchestrator-backend
  • @red-hat-developer-hub/backstage-plugin-orchestrator-common
  • @red-hat-developer-hub/backstage-plugin-orchestrator-form-api
  • @red-hat-developer-hub/backstage-plugin-orchestrator-form-react
  • @red-hat-developer-hub/backstage-plugin-orchestrator

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-bulk-import-backend workspaces/bulk-import/plugins/bulk-import-backend none v5.2.0
@red-hat-developer-hub/backstage-plugin-bulk-import-common workspaces/bulk-import/plugins/bulk-import-common none v1.4.1
@red-hat-developer-hub/backstage-plugin-bulk-import workspaces/bulk-import/plugins/bulk-import none v1.10.3
@red-hat-developer-hub/backstage-plugin-lightspeed-backend workspaces/lightspeed/plugins/lightspeed-backend none v0.1.1
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed none v0.1.3
@red-hat-developer-hub/backstage-plugin-openshift-image-registry workspaces/openshift-image-registry/plugins/openshift-image-registry none v1.10.1
@red-hat-developer-hub/backstage-plugin-orchestrator-backend workspaces/orchestrator/plugins/orchestrator-backend none v4.1.1
@red-hat-developer-hub/backstage-plugin-orchestrator-common workspaces/orchestrator/plugins/orchestrator-common none v1.24.1
@red-hat-developer-hub/backstage-plugin-orchestrator-form-api workspaces/orchestrator/plugins/orchestrator-form-api none v1.4.2
@red-hat-developer-hub/backstage-plugin-orchestrator-form-react workspaces/orchestrator/plugins/orchestrator-form-react none v1.4.3
@red-hat-developer-hub/backstage-plugin-orchestrator-swf-editor-envelope workspaces/orchestrator/plugins/orchestrator-swf-editor-envelope none v1.0.0
@red-hat-developer-hub/backstage-plugin-orchestrator workspaces/orchestrator/plugins/orchestrator none v2.4.1

@04kash 04kash marked this pull request as ready for review November 25, 2024 20:40
yangcao77
yangcao77 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@yangcao77 yangcao77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lightspeed changes looks good to me

rohitkrai03
rohitkrai03 approved these changes Nov 26, 2024
View reviewed changes
Copy link

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 26, 2024
@04kash 04kash merged commit 6e8faef into redhat-developer:main Nov 26, 2024
13 checks passed
@04kash 04kash deleted the clean-up branch November 26, 2024 19:56
karthikjeeyar pushed a commit to karthikjeeyar/rhdh-plugins that referenced this pull request Dec 12, 2024
@04kash @karthikjeeyar
chore: remove unnecessary files from migrated plugins (redhat-develop…
83c493b 
…er#77)

Signed-off-by: Kashish Mittal <[email protected]>
04kash added a commit to 04kash/rhdh-plugins that referenced this pull request Dec 12, 2024
@04kash
chore: remove unnecessary files from migrated plugins (redhat-develop…
46ae1be 
…er#77)

Signed-off-by: Kashish Mittal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangcao77 yangcao77 yangcao77 approved these changes

@batzionb batzionb batzionb approved these changes

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@mareklibra mareklibra Awaiting requested review from mareklibra mareklibra is a code owner

@gciavarrini gciavarrini Awaiting requested review from gciavarrini gciavarrini is a code owner

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar karthikjeeyar is a code owner

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov christoph-jerolimov is a code owner

@debsmita1 debsmita1 Awaiting requested review from debsmita1 debsmita1 is a code owner

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta divyanshiGupta is a code owner

@rm3l rm3l Awaiting requested review from rm3l rm3l is a code owner

Assignees

@rohitkrai03 rohitkrai03

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@04kash @rohitkrai03 @batzionb @yangcao77