Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(update): Updating Channel to trigger an Operator Update #469

Open
wants to merge 5 commits into
base: release-1.3
Choose a base branch
from

Conversation

Fortune-Ndlovu
Copy link
Contributor

@Fortune-Ndlovu Fortune-Ndlovu commented Nov 28, 2024

Description

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHIDP-4687

PR acceptance criteria

How to test changes / Special notes to the reviewer

@@ -42,7 +42,7 @@ metadata:
features.operators.openshift.io/token-auth-gcp: "false"
repository: https://gitlab.cee.redhat.com/rhidp/rhdh/
support: Red Hat
skipRange: '>=1.0.0 <1.3.2'
skipRange: '>=1.2.0 <1.3.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while valid, why do we need to change this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from 1.0.0 means a direct update from, say, 1.1.0 to 1.3.2, no? Could this be an issue, knowing the possible breaking changes that might happen across minor versions of the operand? Would it make more sense to allow some kind of "progressive" minor upgrades?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, direct updates from earlier versions like 1.1.0 to 1.3.2 could introduce issues. To address this, I am maintaining the replaces field 1.2.5 -> 1.3.2 and ensuring the skipRange limits upgrades to versions within the 1.2.x series.

@nickboldt
Copy link
Member

please link to the JIRA for this change.

Copy link

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants