Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHIDP-4411: Update Dynamic Plugins Software templates to 1.3 #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

RHIDP-4411: Update Dynamic Plugins Software templates to 1.3 #22

wants to merge 3 commits into from

Conversation

jesuino
Copy link
Member

@jesuino jesuino commented Oct 15, 2024 •
edited by openshift-ci bot
Loading

What does this PR do / why we need it

Updating the Dynamic Plugins Software Templates to 1.3.x

Which issue(s) does this PR fix

Fixes #RHIDP-4411?

How to test changes / Special notes to the reviewer

See comments.

@jesuino
Copy link
Member Author

jesuino commented Oct 15, 2024

@debsmita1 would you please check the changes for the frontend template? I noticed that the plugin is not working for me, it shows the following error:

image

I see that the request to retrieve users is failing with 401 error, hence possibly some additional setup is required:

image

Also in the dynamic plugin docs I noticed that it is asked to package the dist-scalprum folder, however in my tests I just copied the dist-dynamic content to my dynamic-plugins-root folder:

note: my plugin id is test13-ft

cp plugins/test13-ft/dist-dynamic/ dynamic-plugins-root/janus-idp-backstage-plugin-test13-ft -r

@gashcrumb Could you kindly confirm that copying the dist-dynamic folder for frontend plugins is the way to go? I remember something changed regarding this. Thanks!

@jesuino jesuino removed the request for review from gashcrumb October 15, 2024 18:26
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gashcrumb, jesuino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@debsmita1
Copy link
Member

I have looked into the template, and I think after the update, with the current app-config auth configuration the github API throws the 401 unauthorized error
I need to update the app configuration but haven't figured out what more must be added for this to work.

@debsmita1
Copy link
Member

debsmita1 commented Nov 25, 2024 •
edited
Loading

I have looked into the template, and I think after the update, with the current app-config auth configuration the github API throws the 401 unauthorized error I need to update the app configuration but haven't figured out what more must be added for this to work.

@jesuino I have raised this jesuino#1 against your branch to fix this issue

gashcrumb
gashcrumb reviewed Nov 25, 2024
View reviewed changes
templates/create-frontend-plugin/docs/features/dynamic-plugin.md
@@ -22,14 +22,14 @@ To be able to run your frontend plugin as a dynamic plugin on Red Hat Developer
mv package $(echo $archive | sed -e 's:\.tgz$::')
```

- Move the resulting directory (janus-idp-backstage-plugin-<pluginName>-<version>) into the `dynamic-plugins-root` folder of your backstage-showcase clone, then run yarn start to start the app.
- Move the resulting directory (ed-hat-developer-hub.backstage-plugin-<pluginName>-<version>) into the `dynamic-plugins-root` folder of your backstage-showcase clone, then run yarn start to start the app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here in "red-hat-developer-hub"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gashcrumb gashcrumb gashcrumb approved these changes

@debsmita1 debsmita1 Awaiting requested review from debsmita1

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesuino @debsmita1 @gashcrumb