Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop gathering completions when completions are added from LSP #638

Open
SCWells72 opened this issue Nov 27, 2024 · 1 comment
Open

Stop gathering completions when completions are added from LSP #638

SCWells72 opened this issue Nov 27, 2024 · 1 comment

Comments

@SCWells72
Copy link
Contributor

In most JetBrains IDEs, when context-specific completions are added, no completions are added from other contributors, specifically the WordCompletionContributor which adds words found in the same document. Right now that's not happening for the LSPCompletionContributor, so you get completion lists like:

Image

Instead LSPCompletionContributor should register itself before WordCompletionContributor and, if LSP-based competions were added, should stop collecting completions, e.g.:

Image

If the user explicitly types the completion trigger more than once, though, additional completions can/should be added to the list:

Image

@SCWells72 SCWells72 changed the title Stop gather completions when completions are added from LSP Stop gathering completions when completions are added from LSP Nov 27, 2024
@SCWells72
Copy link
Contributor Author

See #639.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant