Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: made telemetry service factories lightweight (#67) #76

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: made telemetry service factories lightweight (#67) #76

merged 1 commit into from
Dec 19, 2023

Conversation

adietish
Copy link
Contributor

attempted fix for #67

@adietish adietish marked this pull request as ready for review December 19, 2023 10:12
@adietish adietish self-assigned this Dec 19, 2023
@adietish adietish requested a review from sbouchet December 19, 2023 10:12
@adietish
Copy link
Contributor Author

adietish commented Dec 19, 2023 •
edited
Loading

@sbouchet with this fix, can you still reproduce #67?

ps. would love to fix #67 before I release a new version of the telemetry plugin (with the feedback API).

@adietish adietish mentioned this pull request Dec 19, 2023
Closed
@adietish adietish linked an issue Dec 19, 2023 that may be closed by this pull request
ProcessCanceledException in startup when tries to send telemetry event #67
Closed
sbouchet
sbouchet approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbouchet
Copy link
Contributor

@sbouchet with this fix, can you still reproduce #67?

ps. would love to fix #67 before I release a new version of the telemetry plugin (with the feedback API).

can't reproduce with this PR built locally. let's make a release with it.

@adietish adietish merged commit 5062ca3 into redhat-developer:main Dec 19, 2023
16 checks passed
@adietish adietish deleted the issue-67 branch December 19, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProcessCanceledException in startup when tries to send telemetry event
2 participants
@adietish @sbouchet