Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added feedback service (#73) #74

Merged
merged 5 commits into from
Dec 18, 2023
Merged

feat: added feedback service (#73) #74

merged 5 commits into from
Dec 18, 2023

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Dec 7, 2023 •
edited
Loading

fixes #73

@adietish adietish self-assigned this Dec 7, 2023
@adietish adietish changed the title added feedback service (#73) feat: added feedback service (#73) Dec 7, 2023
@adietish adietish force-pushed the issue-73 branch 10 times, most recently from c6eb77d to 4eb2620 Compare December 8, 2023 13:21
@adietish adietish requested a review from sbouchet December 8, 2023 14:03
@adietish adietish marked this pull request as ready for review December 8, 2023 14:03
@adietish adietish mentioned this pull request Dec 8, 2023
Closed
@adietish adietish marked this pull request as draft December 8, 2023 17:01
@adietish
Copy link
Contributor Author

adietish commented Dec 8, 2023

This is functional. It is using 2 separate message brokers though. I'm trying to use a single one, thus converted this back to a draft.

@adietish adietish force-pushed the issue-73 branch 4 times, most recently from 9995b13 to 01a7bce Compare December 12, 2023 15:54
@adietish adietish marked this pull request as ready for review December 12, 2023 22:42
@sbouchet
Copy link
Contributor

sbouchet commented Dec 14, 2023 •
edited
Loading

Are the events correctly sent to the back end system ? i can't see any on my local env, using the appropriate test.

@adietish
only use 1 message broker
60bb240 
Signed-off-by: Andre Dietisheim <[email protected]>
@adietish
Copy link
Contributor Author

Are the events correctly sent to the back end system ? i can't see any on my local env, using the appropriate test.

What test are you running? The only test that is an integration test is TelemetryMessageBuilderIntegrationTest and both me and fred see it sending messages to segment for telemetry and feedback.
Wondering why you wont

@adietish adietish mentioned this pull request Dec 14, 2023
Merged
@adietish
bump to gradle 8.5
f04ddc3 
Signed-off-by: Andre Dietisheim <[email protected]>
sbouchet
sbouchet approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish adietish merged commit 3691bd1 into redhat-developer:main Dec 18, 2023
16 checks passed
@adietish adietish deleted the issue-73 branch December 18, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add API for feedback only
2 participants
@adietish @sbouchet