Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation of the resource name #743

Open
olkornii opened this issue Apr 9, 2024 · 0 comments
Open

No validation of the resource name #743

olkornii opened this issue Apr 9, 2024 · 0 comments
Milestone

Comments

@olkornii
Copy link
Collaborator

olkornii commented Apr 9, 2024

Steps:

  1. EXEC: "Edit" some resource (ex. Pod)
  2. EXEC: in the editor: add some forbidden characters to the name (ex. ",")
  3. EXEC: inspect the name that is reported in the push notification

Result:
The editor does not complain about the illegal character in the name. The push notification is only using portions of the name (ex. the portion before the ",")
Screencast from 2024-04-08 11-19-37.webm

Expected result:
Editor should error given that the resource name is illegal. There should be no push notification

Rules for kubernetes names are as follows: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/

  • contain no more than 253 characters
  • contain only lowercase alphanumeric characters, '-' or '.'
  • start with an alphanumeric character
  • end with an alphanumeric character
@mohitsuman mohitsuman added this to the 1.4.0 milestone Apr 10, 2024
@adietish adietish removed their assignment Apr 10, 2024
@adietish adietish modified the milestones: 1.4.0, 1.5.0 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants