Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tekton configuration and add a new dockerfile for downstream build #47

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Mangaal
Copy link
Contributor

@Mangaal Mangaal commented Nov 20, 2024

What type of PR is this?

Update tekton configuration and add a new dockerfile for downstream build

/kind enhancement

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 20, 2024

Hi @Mangaal. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Mangaal Mangaal marked this pull request as ready for review November 20, 2024 10:03
@svghadi
Copy link
Member

svghadi commented Nov 20, 2024

/ok-to-test

Comment on lines 22 to 24
release=${CI_CONTAINER_RELEASE} \
upstream-version=${CI_UPSTREAM_VERSION} \
upstream-vcs-ref="${CI_GITOPS_BACKEND_UPSTREAM_COMMIT}" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to find replacements for CI_* env vars. If I am not wrong, these vars are CPAAS specific. We need to figure out konflux equivalent for these or manually define them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svghadi , you are right, I will try to find konflux equivalent for these

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even I need them for dex builds. Let me know if you find them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can address this during release pipeline configurations, shouldn't be a blocker for merging this PR.

@svghadi
Copy link
Member

svghadi commented Nov 26, 2024

@Mangaal - Can you enable multi-platform builds? You need to update build-platforms parma in tekton configs.

  - name: build-platforms
    value:
    - linux/x86_64
    - linux/arm64
    - linux/ppc64le
    - linux/s390x

Signed-off-by: Mangaal <[email protected]>
Comment on lines 36 to 38
- linux/arm64
- linux/ppc64le
- linux/s390x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux/arm64
- linux/ppc64le
- linux/s390x

Let's run PR builds only on amd64. I noticed long delays in setting up build env for non amd archs.

Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
@Mangaal Mangaal requested a review from svghadi November 28, 2024 10:18
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants