Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: reuse request session #92

Open
ktdreyer opened this issue Apr 24, 2018 · 4 comments
Open

RFE: reuse request session #92

ktdreyer opened this issue Apr 24, 2018 · 4 comments
Labels
enhancement

Comments

@ktdreyer
Copy link
Member

As the requests documentation describes, sharing a single requests Session object across each HTTP request means we can reuse the existing TCP connection, increasing performance.
@ktdreyer
Copy link
Member Author

@lcarva pointed me at another ET client today that uses a single requests session with HTTPAdapter and urllib's Retry to fine-tune the retry behavior. We should implement this as well for easier error handling.

yazug added a commit to yazug/errata-tool that referenced this issue Oct 4, 2018
@yazug
WIP: attempt to hack in requests.Session() logic (Issue#92)
34a65c5 
red-hat-storage#92

TODO: unittests monkeypatch needs adjusted
@ktdreyer
Copy link
Member Author

ktdreyer commented Jan 4, 2019

I've pushed a requests-session branch that does this. More testing needed here.

@ktdreyer
Copy link
Member Author

ktdreyer commented Feb 5, 2019

PR @ #146

@yazug
Copy link
Collaborator

yazug commented Nov 14, 2019

interesting tweak https://github.com/containerbuildsystem/osbs-client/blob/master/osbs/http.py#L99

using urllib3 Retry object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yazug @ktdreyer