Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guess_dates should accept vector of column names in clean_dates #76

Open
scottyaz opened this issue May 24, 2019 · 5 comments
Open

guess_dates should accept vector of column names in clean_dates #76

scottyaz opened this issue May 24, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@scottyaz
Copy link

It would be helpful to also allow for character vector specifying column names (or even in tidy notation col_a:col_m. Note this is not a bug.

@zkamvar
Copy link
Member

zkamvar commented May 24, 2019

guess_dates() explicitly works on vectors. Would this not be taken care of by the clean_dates() function, which wraps guess_dates()?

@scottyaz
Copy link
Author

Sorry, I meant the guess_dates argument of clean_dates seems to only accept logical or numeric vectors. Its easy enough to figure out which column numbers we want but would make it easier for many to just be able to specify the names of the columns.

@zkamvar zkamvar added the enhancement New feature or request label May 24, 2019
@zkamvar zkamvar changed the title guess_dates should accept vector of column names guess_dates should accept vector of column names in clean_dates May 24, 2019
@thibautjombart
Copy link
Contributor

Not entirely sure how straightforward the added feature would be. @zkamvar do you think this belong to the prep of release 0.1.0 or shall we put a pin in it for later releases?

For what it's worth, an easy workaround would be, e.g. with dates columns containing the date character string:

x %>% 
  clean_data() %>% 
  mutate_at(vars(contains("date")), guess_dates, error_tolerance = 1)

Assuming a default guess_dates = FALSE in clean_data, cf PR #103

@zkamvar
Copy link
Member

zkamvar commented Nov 14, 2019

Because there is a workaround, I would be much happier to put this on the backburner.

@thibautjombart
Copy link
Contributor

Because there is a workaround, I would be much happier to put this on the backburner.

Perf, untagging this from the project for the first release, and we can always get to this later.

@scottyaz most welcome to PR this if you feel like it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants