Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-mypy option to disable mypy check #138

Open
pwildenhain opened this issue Aug 26, 2022 · 2 comments
Open

Add --no-mypy option to disable mypy check #138

pwildenhain opened this issue Aug 26, 2022 · 2 comments

Comments

@pwildenhain
Copy link

Right now I have --mypy in my pytest.ini file so that mypy runs by default when my tests are run, both locally and in CI

However, when I'm quickly iterating in testing a new feature, I would like to skip the mypy check since I first just want to make sure that the feature works.

Having a --no-mypy option to pass through to pytest when running locally would be great, rather than having to just deal with the mypy run each time, or go and manually modify my pytest.ini file to comment out the --mypy option.

The pytest-pylint and pytest-cov plugins provide this functionality:

I'm happy to add a PR if you agree that this is a worthwhile feature

@jaraco
Copy link

jaraco commented Nov 8, 2022

You might also consider using pytest-enabler, which supplies the behavior you seek and doesn't require each plugin to have its own disable flag. That's what I use in my projects.

@dmtucker
Copy link
Collaborator

I like the idea of a Click-style --no-mypy, but I'm not so sure about promising that --no-mypy will always take precedence when both are passed 🤔

Perhaps --mypy-xfail (which will be included in v1.0.0) could be of use to you?
mypy would still run, but the failures would be reported as xfail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants