-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications: not shown on other people's projects #11333
Comments
We've been hitting this a lot lately and this has triggered a NR alarm. It would be good if we can prioritize this because of the alarm, but also because it's a confusing UX entering a failing project and not knowing why it failed. |
What would be the expected result here? Looks like we aren't showing notifications on purpose readthedocs.org/readthedocs/api/v3/permissions.py Lines 66 to 73 in 019719a
Do all build/project notifications have private information in those? Do we want to show those to all users? If this is just for helping debug a problem, I think we just need to bring impersonate to .org. |
The expected result here is to copy the behavior we used to have: show all build notifications on build detail pages to all users for public projects. The code you showed from the API may have introduced a bug by mistake. Note that if you go to https://app.readthedocs.org/projects/test-builds/builds/24735510/ in an Incognito window, you won't see the build error notification --which is the problem we want to solve. This is not to help us to debug issues, but something that's expected for users to see on public projects. |
Actually, we just receive a support email about this exact same problem: https://app.frontapp.com/open/cnv_ni9id53?key=IXuAcHhM5AG28s077lJ-Tlebut_7QyNp 😄 |
Opening a build details page for a project where you are not a maintainer returns 403 and show no notifications at all.
The text was updated successfully, but these errors were encountered: