Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: not shown on other people's projects #11333

Closed
humitos opened this issue May 21, 2024 · 4 comments · Fixed by #11449
Closed

Notifications: not shown on other people's projects #11333

humitos opened this issue May 21, 2024 · 4 comments · Fixed by #11449
Assignees
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@humitos
Copy link
Member

humitos commented May 21, 2024

Opening a build details page for a project where you are not a maintainer returns 403 and show no notifications at all.

  1. go to https://beta.readthedocs.org/projects/chemprop/builds/24161295/
  2. check the console

Screenshot_2024-04-24_12-45-08

@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels May 21, 2024
@humitos
Copy link
Member Author

humitos commented Jun 1, 2024

We've been hitting this a lot lately and this has triggered a NR alarm. It would be good if we can prioritize this because of the alarm, but also because it's a confusing UX entering a failing project and not knowing why it failed.

@stsewd
Copy link
Member

stsewd commented Jun 27, 2024

What would be the expected result here? Looks like we aren't showing notifications on purpose

if view.basename not in (
"projects-notifications",
"projects-builds-notifications",
):
# We don't want to give detail access to resources'
# notifications to users that don't have access to those
# resources.
return True

Do all build/project notifications have private information in those? Do we want to show those to all users? If this is just for helping debug a problem, I think we just need to bring impersonate to .org.

@humitos
Copy link
Member Author

humitos commented Jul 1, 2024

The expected result here is to copy the behavior we used to have: show all build notifications on build detail pages to all users for public projects.

The code you showed from the API may have introduced a bug by mistake.

Note that if you go to https://app.readthedocs.org/projects/test-builds/builds/24735510/ in an Incognito window, you won't see the build error notification --which is the problem we want to solve. This is not to help us to debug issues, but something that's expected for users to see on public projects.

@humitos
Copy link
Member Author

humitos commented Jul 1, 2024

Actually, we just receive a support email about this exact same problem: https://app.frontapp.com/open/cnv_ni9id53?key=IXuAcHhM5AG28s077lJ-Tlebut_7QyNp 😄

stsewd added a commit that referenced this issue Jul 11, 2024
…ects (#11449)

* API V3: Allow other users to see build notifications from public projects

Fixes #11333

* Fix tests

* Fix

* Update docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
Archived in project
2 participants