Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API V3: Allow other users to see build notifications from public projects #11449

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jul 4, 2024

  • Use an explicit permission class instead of relying on the "global" one (PublicDetailPrivateListing).
  • Use Build.objects.api to filter the build, since that takes into consideration the privacy level of the project/version/external version. We could move this one to the parent class if we want to have all resources that involve build have that same behavior.

Fixes #11333

@stsewd stsewd changed the title API V3: Allow other users to see build notifications from public proj… API V3: Allow other users to see build notifications from public projects Jul 4, 2024
@stsewd stsewd marked this pull request as ready for review July 9, 2024 16:55
@stsewd stsewd requested a review from a team as a code owner July 9, 2024 16:55
@stsewd stsewd requested a review from humitos July 9, 2024 16:55
@stsewd stsewd merged commit 75e155f into main Jul 11, 2024
8 checks passed
@stsewd stsewd deleted the allow-other-users-to-see-build-notifications branch July 11, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications: not shown on other people's projects
2 participants