Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing: use same buttons pattern for builds and versions listing #415

Open
humitos opened this issue Jul 4, 2024 · 1 comment
Open
Labels
Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented Jul 4, 2024

I think we have been happy with the pattern we have in the version listing with those buttons at the right:

Screenshot_2024-07-04_14-08-07

Today I found that those buttons are different in the build listing page but it seems we should be able to use the same pattern:

Screenshot_2024-07-04_14-08-42

Why we don't we move the content from the chip into the list item? The "Book" icon could be a button, similar to the version listing page, and the other two links could be inside the "..." (dots) dropdown. That way we remove the extensive usage of chips that require hovering --which is usually harder than just a simple click.

@humitos humitos added the Needed: design decision A core team decision is required label Jul 4, 2024
@agjohnson
Copy link
Contributor

We shouldn't alter the version popupcard. The intention with that UI is not to supplement UI in the build listing view. Instead the buttons should exist in both, it sounds like mostly just a view docs button that we should add to the buttons list.

A few things there:

  • We don't have the URL of the built documentation and this is a slow query. In other UIs, this is an async call against APIv3 on buttons hover.
  • There are probably issues with the API used here. It might be stuck using APIv2, if at least for reasons like
  • If we can use APIv3 we should have the resolved URL already, if not we might be stuck with what APIv2 can give us.
  • That resync button uses APIv3 now at least.

@agjohnson agjohnson added this to the New dashboard features milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants