Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout: display language when collapsed #359

Closed
nijel opened this issue Aug 7, 2024 · 2 comments · Fixed by #360
Closed

Flyout: display language when collapsed #359

nijel opened this issue Aug 7, 2024 · 2 comments · Fixed by #360
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@nijel
Copy link

nijel commented Aug 7, 2024 •
edited
Loading

What's the problem this feature will solve?

When users browse the documentation, they are unaware that it is available in other languages.

Describe the solution you'd like

Make the language selection visible in the flyout before expanding (for projects that have multiple languages) similarly like the currently selected version is visible.

Alternative solutions

The language selection is there, but people won't notice it unless they are aware of the option.

Additional context

Can be seen at https://docs.weblate.org/en/latest/.
@nijel nijel changed the title Addons: Display language in an unexpanded selector Addons: Display language in flyout Aug 7, 2024
@humitos humitos changed the title Addons: Display language in flyout Flyout: display language when collapsed Aug 8, 2024
@humitos
Copy link
Member

humitos commented Aug 8, 2024

Hi 👋🏼 . Thanks for this suggestion 👍🏼

I'm moving this issue to the addons repository which is where the code for the flyout lives.

@humitos humitos added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Aug 8, 2024
@humitos humitos transferred this issue from readthedocs/readthedocs.org Aug 8, 2024
humitos added a commit that referenced this issue Aug 8, 2024
@humitos
Flyout: show language in header
66a61be 
This is a simple an quick implementation of #359 just as a way to share an idea.
We can discuss here if this is the path we want to follow or not. I'm open for changes.

Closes #359
@humitos humitos mentioned this issue Aug 8, 2024
Merged
@humitos
Copy link
Member

humitos commented Aug 8, 2024

I opened #360 as an example. I'd appreciate your feedback there.

@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Aug 19, 2024
humitos added a commit that referenced this issue Oct 10, 2024
@humitos
Flyout: show language in header (#360)
c958fa8 
This is a simple an quick implementation of #359 just as a way to share
an idea. We can discuss here if this is the path we want to follow or
not. I'm open for changes.


![Screenshot_2024-08-08_12-57-27](https://github.com/user-attachments/assets/21e83432-5cad-4a82-a890-56cba6a76e45)


Closes #359
@github-project-automation github-project-automation bot moved this from Planned to Done in 📍Roadmap Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flyout: show language in header readthedocs/addons
2 participants
@nijel @humitos