-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the "Multiple versions without translations (/<version>/<filename>
)" versioning scheme
#42
Comments
/<version>/<filename>
)" versioning scheme/<version>/<filename>
)" versioning scheme
I can probably take some time to submit a PR in the coming days, would that be of interest to you @humitos? |
I think we should add a new attribute called "versioning-scheme" (which is what the APIv3 uses https://docs.readthedocs.io/en/stable/api/v3.html#project-details) and base the URL on that. |
Also, now that APIv3 is open and un-authed, we could propbably only ask the user for the |
I see, that makes sense. Seems like with the response from
|
We shouldn't rely on this API for all projects, on .com projects are private, and we can't hit the API directly for those without auth. |
Gotcha. It's probably better then to deprecate |
Currently only two schemes are supported by this action:
actions/preview/scripts/edit-description.js
Lines 20 to 24 in 43ac444
Which correspond to "Single version without translations (
/<filename>
)" and "Multiple versions with translations (/<language>/<version>/<filename>
)" respectively.Fix might be adding a new option (e.g.
no-translations
) or a special valuenone
for project-language
, and use that in a condition to build the right URL.The text was updated successfully, but these errors were encountered: