Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding specific libuv adapter #74

Open
clue opened this issue Apr 22, 2019 · 2 comments
Open

Consider adding specific libuv adapter #74

clue opened this issue Apr 22, 2019 · 2 comments

Comments

@clue
Copy link
Member

clue commented Apr 22, 2019

We may want to add a specific adapter taking advantage of libuv's process handling logic:

To be clear, this project works just fine with all loop implementations, including the default StreamSelectLoop and ExtUvLoop. This potential adapter could take advantage of some of the optimizations inside libuv and avoid some of the known limitations of the project.

In particular, this may help with Windows support (#9) in the future because libuv supports pipes with overlapped mode on Windows. Note that a Windows build of ext-uv does not appear to be available at the time of writing this, but it is believed to change again in the future (amphp/ext-uv#63).

@bwoebi
Copy link

bwoebi commented Apr 28, 2019

Note that I've fixed the building on windows for php-uv.

@ghost ghost mentioned this issue Apr 28, 2019
@clue
Copy link
Member Author

clue commented Apr 26, 2020

See also @CharlotteDunois's excellent version here: https://github.com/AndromedaGalaxy/reactphp-libuv-process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants