Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo]: createPortal documentation is pointing to an old page of W3C dialog modal docs. #6951

Open
PedroBarbosaSw opened this issue Jun 14, 2024 · 2 comments · May be fixed by #6956
Open

[Typo]: createPortal documentation is pointing to an old page of W3C dialog modal docs. #6951

PedroBarbosaSw opened this issue Jun 14, 2024 · 2 comments · May be fixed by #6956

Comments

@PedroBarbosaSw
Copy link

PedroBarbosaSw commented Jun 14, 2024

Summary

createPortal documentation redirect us to the wrong W3C guideline page (old page).

Page

https://react.dev/reference/react-dom/createPortal#usage

Details

The createPortal documentation (Pitfall section) has a link that points to the W3C guidelines page on how to make modals accessible.
Although, this link is an old one so this is not currently redirecting to the expected one. The new link is https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/.

@baskargopinath baskargopinath linked a pull request Jun 16, 2024 that will close this issue
Rekl0w added a commit to Rekl0w/react.dev that referenced this issue Jun 16, 2024
@Rekl0w
Copy link
Contributor

Rekl0w commented Jun 16, 2024

You looks like made the changes first, go ahead.

@baskargopinath
Copy link

thanks @Rekl0w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants