Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for function components that return null #924

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add support for function components that return null #924

wants to merge 5 commits into from

Conversation

rvetere
Copy link

@rvetere rvetere commented May 27, 2024 •
edited
Loading

Add support for function components that only return null:

export const DataTableColumnDocs: FunctionComponent<
  IDataTableColumn<object>
> = () => {
  return null;
};

and add support for components that only return a prop (directly, without a fragment):

export const AuthenticatedBoundary = ({
  children,
  fallback,
}: AuthenticatedBoundaryProps) => {
  const { isLoggedIn } = useAuthentication();

  if (!isLoggedIn) {
    return fallback;
  }

  return children;
};

Fixes #926

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 656b2f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited
Loading

✅ Deploy Preview for react-docgen ready!

Name Link
🔨 Latest commit 656b2f3
🔍 Latest deploy log https://app.netlify.com/sites/react-docgen/deploys/66557967c7dbfb0008ac0d97
😎 Deploy Preview https://deploy-preview-924--react-docgen.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No support for components that directly return null
1 participant
@rvetere