Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of import_module in idom.run #764

Closed
rmorshea opened this issue Jun 17, 2022 · 1 comment
Closed

Remove usage of import_module in idom.run #764

rmorshea opened this issue Jun 17, 2022 · 1 comment
Labels
priority-3-low May be resolved one any timeline.

Comments

@rmorshea
Copy link
Collaborator

Current Situation

There was a bug in idom.run because we failed to update an import after a name change.

Proposed Actions

We used import_module("idom.backend.default") presumably because it was syntactically convenient to write this. Instead we should just do an actual import:

if not implementation:  # pragma: no cover
    from idom.backend import default as implementation
@rmorshea rmorshea added flag-triage Not prioritized. priority-3-low May be resolved one any timeline. and removed flag-triage Not prioritized. labels Jun 17, 2022
@rmorshea rmorshea added this to the 2.0 milestone Jun 17, 2022
@rmorshea rmorshea removed this from the Luxury milestone Feb 21, 2023
@Archmonger
Copy link
Contributor

Closing this in favor of #1113

@Archmonger Archmonger closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low May be resolved one any timeline.
Projects
None yet
Development

No branches or pull requests

2 participants