Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rvn_rvh_cleanhrus #49

Open
rchlumsk opened this issue Dec 12, 2020 · 2 comments
Open

rvn_rvh_cleanhrus #49

rchlumsk opened this issue Dec 12, 2020 · 2 comments

Comments

@rchlumsk
Copy link
Owner

Requires Area in the subbasin df but this is only produced when reading the rvh file, not when providing a direct data frame

should have a check in this function and automatically tabulate the subbasin areas if needed

@rchlumsk
Copy link
Owner Author

Additional issue with this function, the area_tol= xxx other than default causes an issue in merging data frames,

dd <- rvn_rvh_cleanhrus(HRUtab=rvh$HRUtable, SBtab=rvh$SBtable, area_tol=0.05)
Error in $<-.data.frame(*tmp*, "remove", value = c(TRUE, TRUE, TRUE, :
replacement has 6226 rows, data has 9784

@rchlumsk
Copy link
Owner Author

Also add check for duplicate HRU IDs, merge automatically (?) assuming other properties remain the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant