Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify_payment_signature does not throw error if wrong attributes are passed #93

Open
tannakartikey opened this issue Oct 25, 2020 · 1 comment
Assignees

Comments

@tannakartikey
Copy link

By mistake I passed signature instead of razorpay_signature to verify_payment_signature. Code failed under secure_compare(a,b) with error that method bytesize not available on nil.

I think it should fail straight away under verify_payment_signature

Something like:

  def self.verify_payment_signature(attributes)
    signature = attributes.delete(:razorpay_signature) { |k| fail ArgumentError, k }
    # .....
  end
@ankitdas13
Copy link
Contributor

Hi @tannakartikey Apologise for the long delay. As i have also tested this issue, i am getting the same error . i will discuss this with my team and let you know when it is resolved.
Thanks for reporting this issue.

@ankitdas13 ankitdas13 self-assigned this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants